-
Notifications
You must be signed in to change notification settings - Fork 3
Re-run Sage 2.1.0 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run-optimization-benchmarks submissions/2025-10-20-Sage-2.1.0/input.yaml |
|
A workflow has been dispatched to run the benchmarks for this PR.
|
|
A workflow dispatched to run optimization benchmarks for this PR has just finished.
|
|
I'm seeing some differences between this run and Both RMSD results on the same plot: Distribution of RMSD differences: Both DDE results on the same plot: Distribution of DDE differences: Here's the code I used to generate these plots and statistics, which I ran from this branch |
|
That's a lot for 5 minutes! I've done much less in much more time this morning. Here's a subset of environment differences, none of which should be a smoking gun: {'openeye-toolkits': ('2024.1.3', '2025.1.1'),
'openff-amber-ff-ports': ('0.0.4', '2025.09.0'),
'openff-forcefields': ('2024.09.0', '2025.10.0'),
'openff-interchange': ('0.4.0', '0.4.8'),
'openff-interchange-base': ('0.4.0', '0.4.8'),
'openff-qcsubmit': ('0.53.0', '0.57.0'),
'openff-toolkit': ('0.16.5', '0.17.1'),
'openff-toolkit-base': ('0.16.5', '0.17.1'),
'openff-units': ('0.2.2', '0.3.1'),
'openff-utilities': ('0.1.12', '0.1.16'),
'openmm': ('8.1.2', '8.3.1'),
'rdkit': ('2024.03.5', '2025.03.6')}The automation does a I've pulled out a few molecules which get high ICRMSD differences but it's hard to draw conclusions quickly. I will pick this up later. Otherwise I've
|
|
For now I will follow your recommendation to keep this moving along. There's lots we can do to make these analyses easier; the barrier here was higher than I hoped it to be |
|
Not sure where to put this analysis, but for now I'll just infodump on a few molecules I looked at Key take-aways
To get another picture of the sort of differences in these YDS runs, here's a
I'm somewhat (?) reassured that the order of magnitude of bond differences is quite small and even the top quartile is not so bad. The order of magnitude of angle differences also seems good, even the maximum value. Torsion differences are more suspect in the middle and very suspect on the high end - so far, these seem to be where minimizing to a different conformer shows up quantitatively. Generally suspicious molecules36966572This molecule is just ... sorta cursed. I don't know if phosphates truly like to comprise part of a (7-membered) ring but the 3-D structure is quite poor, mostly at the phosphate group. Here are bonds labeled by how much bonds diff (between QM and MM) when the difference is more than 0.02 Angstroms:
This molecule has the worst bond RMSD in (both) 2.1.0 runs and was the top of discussion in one of Chapin's bug reports. This is not necessarily relevant to the reproducibility of YDS runs, but notable. |
|
Here's the notebook I've been using - in its current state, tidied up only partially, and note production-quality work: Compare.ipynb.txt |






















Submission Checklist
submissionsdirectory containing the YDS input file and optionally a force field.offxmlfile/run-optimization-benchmarks path/to/submission/input.yamlor/run-torsion-benchmarks path/to/submission/input.yamlJob status: successto be posted